Description of changes

Bug fixes and cleanup of map and fractions mod

Specific notes

This fixes a substantial bug in that the ice/ocean mask was mapped from the ocean mesh to the atm mesh using conservative mapping with a normtype of DSTFRAC rather than a normtype of DSTAREA. The result was that the land fraction on the atm mesh was always just 0/1 and the ocean fraction in non-polar regions was 0/1 on the coasts. This PR fixes this.

Also, as part of this PR a clean up of med_map_mod.F90 was done for generating the maps that were needed by med_fraction_mod.F90.

Contributors other than yourself, if any: mvertens

CMEPS Issues Fixed (include github issue #): #106

Are changes expected to change answers?

• bit for bit - for most compsets other than B and X compsets
• different at roundoff level - for some compsets other than B and X compsets
• more substantial - for B and X compsets

Any User Interface Changes (namelist or namelist defaults changes)?

• Yes
• No

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

• (required) CIME_DRIVER=nuopc scripts_regression_tests.py
  • machines: cheyenne
  • details (e.g. failed tests):
• (required) CESM testlist_drv.xml
  • machines and compilers: cheyenne, intel
  • details (e.g. failed tests): generate oct05, compare aug19
• (optional) CESM prealpha test
  • machines and compilers
  • details (e.g. failed tests):

Testing performed if application target is UFS-S2S:

• (required) UFS-S2S testing
  • description: testing was done by @DeniseWorthen to demonstrate that this bug fix was also needed in the UFS.
  • details: The tests compared results of running simulations with and without the bug fix for c384mx025

Hashes used for testing:

• CESM:

  • repository to check out: https://github.com/ESCOMP/CESM.git
  • branch: nuopc_dev
  • hash: d0e271c
    (cime is on master, hash 516f7c2755)

• UFS-S2S, then umbrella repostiory to check out and associated hash:

  • repository to check out:
  • branch:
  • hash: